cleanup GUI special member functions (#1387)
authortsteven4 <13596209+tsteven4@users.noreply.github.com>
Sun, 24 Nov 2024 22:34:33 +0000 (15:34 -0700)
committerGitHub <noreply@github.com>
Sun, 24 Nov 2024 22:34:33 +0000 (15:34 -0700)
commitb8068b91e440747dedad0eeb691e701d2fa13d5d
tree13fbcca3532b4eb2c25ee4b69bcb61cfdaf8fca5
parenta9a2049f671fc9674fa7c3fa8525442054ba2e6c
cleanup GUI special member functions (#1387)

* cleanup gui special member functions

These tidy checks had a large impact:
cppcoreguidelines-prefer-member-initializer
modernize-use-default-member-init
modernize-use-equals-default

Some instances of other tidy issues were resolved:
clang-analyzer-optin.cplusplus.VirtualCall
cppcoreguidelines-special-member-functions
readability-inconsistent-declaration-parameter-name
readability-named-parameter
and others.

Overall we have 1334 fewer tidy checks on our code base, a
reduction of 15% of the total!

The user defined dtor for class SettingGroup was eliminated
by using std::vector<std::unique_ptr<VarSetting>> instead of a
QList of raw pointers.
The user defined dtor for class FilterWidget was eliminated
by using std::vector<std::unique_ptr<FilterOption>> instead of a
QList of raw pointers.
gui/babeldata.h
gui/filterdata.cc
gui/filterdata.h
gui/filterwidgets.cc
gui/filterwidgets.h
gui/mainwindow.cc
gui/setting.h